Suspend resume broken since 4.9

Hsu, Ryan ryanhsu at
Mon Mar 6 11:36:54 PST 2017

+ ath10k list, wasn't intended to send it privately, adding the list back.

On 03/06/2017 10:40 AM, Ryan Hsu wrote:
> On 03/06/2017 08:43 AM, Enrico Tagliavini wrote:
>> Assuming this doesn't make sense I assume the only mistake I might
>> have maid was marking 05ee799f2021658cc0fc64c1f05c940877b90724 as
>> good. And who knows maybe it was not even a mistake maybe it was a
>> fluke it worked. Doesn't really matter. I guess what I have to do is
>> to restart the bisect, mark v4.8 good and
>> 05ee799f2021658cc0fc64c1f05c940877b90724 bad and keep going.
>> Am I right?
> Yes, this would be the same I would try.
> And I happened to try this last weekend and I could see it works after reverting the change.
> ebee76f7fa46 ("ath10k: allow setting coverage class").
> I haven't figured out the clue why it randomly failed.
> But the original changes seems to be leveraging the work from ath9k, but those register address doesn't completely apply for QCA6174.
> Since the set_coverage_class.ops in my QCA6174 card seems to read the incorrect value and always failed to set to hw.
> Even the address base is correct, so I guess other register offset might be incorrect as well...  so I planned to remove that ops from QCA6174 later.
> Could you either revert the commit or just changes the wlan_mac_base_address to see if that helps?
> --- a/drivers/net/wireless/ath/ath10k/hw.c
> +++ b/drivers/net/wireless/ath/ath10k/hw.c
> @@ -51,7 +51,7 @@
>         .rtc_soc_base_address                   = 0x00000800,
>         .rtc_wmac_base_address                  = 0x00001000,
>         .soc_core_base_address                  = 0x0003a000,
> -       .wlan_mac_base_address                  = 0x00020000,
> +       .wlan_mac_base_address                  = 0x00010000,
>         .ce_wrapper_base_address                = 0x00034000,
>         .ce0_base_address                       = 0x00034400,
>         .ce1_base_address                       = 0x00034800,
> Ryan

More information about the ath10k mailing list