[1/2] ath10k: add accounting for the extended peer statistics
kvalo at qca.qualcomm.com
Wed Jan 11 02:49:20 PST 2017
Christian Lamparter <chunkeey at googlemail.com> writes:
> Hello Shafi and Kalle,
> On Tuesday, January 3, 2017 10:58:27 AM CET Mohammed Shafi Shajakhan wrote:
>> On Fri, Dec 30, 2016 at 03:35:10PM +0100, Christian Lamparter wrote:
>> > On Thu, Dec 29, 2016 at 3:11 PM, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
>> > > Christian Lamparter <chunkeey at googlemail.com> wrote:
>> > >> The 10.4 firmware adds extended peer information to the
>> > >> firmware's statistics payload. This additional info is
>> > >> stored as a separate data field and the elements are
>> > >> stored in their own "peers_extd" list.
>> > >>
>> > >> These elements can pile up in the same way as the peer
>> > >> information elements. This is because the
>> > >> ath10k_wmi_10_4_op_pull_fw_stats() function tries to
>> > >> pull the same amount (num_peer_stats) for every statistic
>> > >> data unit.
>> > >>
>> > >> Fixes: 4a49ae94a448faa ("ath10k: fix 10.4 extended peer stats update")
>> > >> Signed-off-by: Christian Lamparter <chunkeey at googlemail.com>
>> > >
>> > > My understanding is that I should skip this patch 1. Please let me know if
>> > > I misunderstood. But I'm still plannning to apply patch 2.
>> > I added Mohammed (I hope, he can reply to the open question when he
>> > returns), Since I'm not sure what he wants or not.
>> > As far as I'm aware, the "extended" boolean serves no purpose
>> > because it was only used in once place in debugfs_sta which was
>> > removed in the patch. ( "ath10k_sta_update_stats_rx_duration"
>> > and "ath10k_sta_update_extd_stats_rx_duration" have been unified).
>> [shafi] We will wait for Kalle to review from the de-ferred stage
>> and get his opinion as well(regarding the design change).
>> I have no concerns as long this does not changes the existing behaviour.
>> thank you !
> Thank you Shafi for sticking around. I just fished your response to
> "Re: [PATCH] ath10k: merge extended peer info data with existing peers info" .
> out of my spam-bucket. Kalle, please look if your copy of the mail got
> flagged/deleted as well. Judging from the reply in this thread, I think you
> overlooked it as well?
I think I just read the discussion to hastily as it was rather long,
sorry about that.
After really long or confusin discussions, just to help the maintainers
and also avoid miscommunication between participants, it's usually a
good idea to summarise the conclusion. If us maintainers need to figure
out the conclusion ourselves from a long discussion we are bound to make
mistakes, just like I did here.
So something like this would help me a lot:
"Kalle, please drop these patches. I need to work on these a bit more."
"Kalle, me and John came to agreement about foo. So these should be good
> After reading it, I think the previous post and the request to put the patch
> on wait was unnecessary. As of now, it seems to me that the open questions
> between us have been settled amically (so to speak). Kalle, do you have any
> concerns or can you put this in the next round then?
If you both are happy with the patch, I'm happy to take it :)
I actived the patch again in my queue by moving the state from Deferred
If all goes well I'm expecting to apply it later this week.
More information about the ath10k