[PATCH] ath10k: Fix mgmt tx status for 10.4.3 firmware.

Felix Fietkau nbd at openwrt.org
Tue Mar 1 01:26:42 PST 2016


On 2016-02-29 22:50, greearb at candelatech.com wrote:
> From: Ben Greear <greearb at candelatech.com>
> 
> When testing a 10.4.3 firmware in station mode, I notice that
> when the AP is powered down, the ath10k does not notice AP is gone
> because mgt frames get tx status of 3, which is not handled.
> 
> It appears that status 3 means something similar to failed-retry.
> 
> Treating it thus lets the station disconnect properly.
> 
> Tested against a non-stock 10.4.3 firmware, but likely upstream
> firmware acts similarly in this case.
> 
> Signed-off-by: Ben Greear <greearb at candelatech.com>
> ---
> 
> This patch is against a heavily patched tree based on 4.4, hopefully
> it can be applied to upstream code w/out too much trouble.
> 
> Someone should verify this on stock 10.4-ish firmware before applying.
> 
>  drivers/net/wireless/ath/ath10k/htt.h    |  4 +++-
>  drivers/net/wireless/ath/ath10k/htt_rx.c | 11 +++++++++--
>  2 files changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath10k/htt.h b/drivers/net/wireless/ath/ath10k/htt.h
> index c31a31f..de663a6 100644
> --- a/drivers/net/wireless/ath/ath10k/htt.h
> +++ b/drivers/net/wireless/ath/ath10k/htt.h
> @@ -309,7 +309,9 @@ struct htt_mgmt_tx_desc {
>  enum htt_mgmt_tx_status {
>  	HTT_MGMT_TX_STATUS_OK    = 0,
>  	HTT_MGMT_TX_STATUS_RETRY = 1,
> -	HTT_MGMT_TX_STATUS_DROP  = 2
> +	HTT_MGMT_TX_STATUS_DROP  = 2,
> +	HTT_MGMT_TX_STATUS_TXFILT = 3 /* Seems to be logically similar to
> +					 RETRY failure. */
In that case the driver should probably set IEEE80211_TX_STAT_TX_FILTERED

- Felix



More information about the ath10k mailing list