[PATCH v2] cfg80211: add VHT support for Mesh

Johannes Berg johannes at sipsolutions.net
Thu Nov 12 13:40:13 PST 2015

On Thu, 2015-11-12 at 13:33 -0800, Peter Oh wrote:
> At this moment Mesh Point is not able to be brought up by userspace
> such 
> as wap_supplicant at VHT data rates because there is no
> events/NL80211 
> defined that userspace can check out if drivers can support Mesh
> Point 
> (802.11s) at VHT data rates or not, hence only HT data rates can be
> used 
> for
> Mesh Point by userspace now.
> This patch is introducing NL80211 event to cover the issue.

No... this patch doesn't introduce an nl80211 event. It introduces a
feature flag, but I'm arguing it's useless.

Look - what's the difference that userspace would do based on this
flag? Clearly, setting the flag in the driver has no effect on kernel
code whatsoever, so your "is not able to be brought up" makes no sense.

Perhaps it'll become clearer once you post the wpa_supplicant code, but
you should still coherently explain in the commit message why this is
necessary. So far, I don't see it, since no kernel code ever depends on
this flag.


More information about the ath10k mailing list