[PATCH] ath10k: add additional fw build version to info print

Michal Kazior michal.kazior at tieto.com
Mon Jan 12 05:10:41 PST 2015

On 12 January 2015 at 13:56, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
>> Signed-off-by: Michal Kazior <michal.kazior at tieto.com>
>>  void ath10k_print_driver_info(struct ath10k *ar)
>>  {
>> -     ath10k_info(ar, "%s (0x%08x, 0x%08x) fw %s api %d htt %d.%d wmi %d cal %s max_sta %d\n",
>> +     ath10k_info(ar, "%s (0x%08x, 0x%08x) fw %s api %d htt %d.%d wmi %d cal %s max_sta %d build %u.%u.%u.%u\n",
> So now we print two different firmware versions to the user? That's just
> confusing. It's ok to print this build id in debug level, but not in
> info level. From user's point of view we should have only one firmware
> version.

I guess we shouldn't be printing htt version then too. Nevertheless I
understand your concern.

> I would rather make sure that ATH10K_FW_IE_FW_VERSION always contains
> the correct version string and then developers map whatever they need
> from that string.

Right. Let's drop this for now then.


More information about the ath10k mailing list