[PATCH] ath10k: add additional fw build version to info print

Kalle Valo kvalo at qca.qualcomm.com
Mon Jan 12 04:56:23 PST 2015

Michal Kazior <michal.kazior at tieto.com> writes:

> The wmi-tlv firmware contains additional
> versioning info. It may help reporting/debugging.
> Signed-off-by: Michal Kazior <michal.kazior at tieto.com>


>  void ath10k_print_driver_info(struct ath10k *ar)
>  {
> -	ath10k_info(ar, "%s (0x%08x, 0x%08x) fw %s api %d htt %d.%d wmi %d cal %s max_sta %d\n",
> +	ath10k_info(ar, "%s (0x%08x, 0x%08x) fw %s api %d htt %d.%d wmi %d cal %s max_sta %d build %u.%u.%u.%u\n",
>  		    ar->hw_params.name,
>  		    ar->target_version,
>  		    ar->chip_id,
> @@ -134,7 +134,11 @@ void ath10k_print_driver_info(struct ath10k *ar)
>  		    ar->htt.target_version_minor,
>  		    ar->wmi.op_version,
>  		    ath10k_cal_mode_str(ar->cal_mode),
> -		    ar->max_num_stations);
> +		    ar->max_num_stations,
> +		    ar->fw_build_major,
> +		    ar->fw_build_minor,
> +		    ar->fw_build_si,
> +		    ar->fw_build_crm);

So now we print two different firmware versions to the user? That's just
confusing. It's ok to print this build id in debug level, but not in
info level. From user's point of view we should have only one firmware

I would rather make sure that ATH10K_FW_IE_FW_VERSION always contains
the correct version string and then developers map whatever they need
from that string.

Kalle Valo

More information about the ath10k mailing list