[PATCH] ath10k: add modparam 'hw_csum' to make HW checksum configurable

Peter Oh poh at codeaurora.org
Wed Dec 16 12:29:14 PST 2015

On 12/16/2015 10:27 AM, Felix Fietkau wrote:
> On 2015-12-16 19:20, Peter Oh wrote:
>> Some hardwares such as QCA988X and QCA99X0 doesn't have
>> capability of checksum offload when frame formats are not
>> suitable for it such as Mesh frame.
>> Hence add a module parameter, hw_csum, to make checksum offload
>> configurable during module registration time.
>> Signed-off-by: Peter Oh <poh at qca.qualcomm.com>
> How about instead of inventing yet another crappy module parameter, you
> call skb_checksum_help() in the driver in cases where the hardware is
> unable to offload the checksum calculation.
> That way the user has to worry about less driver specific hackery ;)
That will be good option for hardware not supporting HW checksum, but I 
mind that using the function will add more workload per every packet on 
critical data path when HW supports checksum resulting in throughput down.
> - Felix
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

More information about the ath10k mailing list