[PATCH] ath10k: add modparam 'hw_csum' to make HW checksum configurable

Felix Fietkau nbd at openwrt.org
Wed Dec 16 10:27:28 PST 2015


On 2015-12-16 19:20, Peter Oh wrote:
> Some hardwares such as QCA988X and QCA99X0 doesn't have
> capability of checksum offload when frame formats are not
> suitable for it such as Mesh frame.
> Hence add a module parameter, hw_csum, to make checksum offload
> configurable during module registration time.
> 
> Signed-off-by: Peter Oh <poh at qca.qualcomm.com>
How about instead of inventing yet another crappy module parameter, you
call skb_checksum_help() in the driver in cases where the hardware is
unable to offload the checksum calculation.

That way the user has to worry about less driver specific hackery ;)

- Felix



More information about the ath10k mailing list