[PATCH 0/4] ath10k: fix/cleanup fw stats

Joe Perches joe at perches.com
Fri Sep 26 07:14:21 PDT 2014

On Fri, 2014-09-26 at 13:14 +0200, Michal Kazior wrote:
> On 26 September 2014 13:06, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
> > drivers/net/wireless/ath/ath10k/wmi.c:1513: WARNING: else is not generally useful after a break or return
> I'm aware of this one but the code looks nicer with the `else` to me though.

Yay Michal.

Always use your taste over any mindless style tool.

Ignore any checkpatch complaint you want.

btw: checkpatch shouldn't warn about this as of:

commit adefeef310ee8bd3923d41b67bc53c398bc53621
Author: Joe Perches <joe at perches.com>
Date:   Fri Sep 26 10:19:29 2014 +1000

    checkpatch: add exception to return then else test
    Add an exception to the return before else warning
    when the line following it is also a return like:
        if (foo)
                return bar;
                return baz;
    This form of a test then return is at least as readable as
        if (foo)
                return bar;
        return baz;
    so don't emit a warning on the first form.
    Signed-off-by: Joe Perches <joe at perches.com>
    Reported-by: Al Viro <viro at ZenIV.linux.org.uk>
    Cc: Elshad Mustafayev <elshadimo at gmail.com>
    Signed-off-by: Andrew Morton <akpm at linux-foundation.org>

More information about the ath10k mailing list