[PATCH 0/4] ath10k: fix/cleanup fw stats

Michal Kazior michal.kazior at tieto.com
Fri Sep 26 04:14:35 PDT 2014

On 26 September 2014 13:06, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
> Michal Kazior <michal.kazior at tieto.com> writes:
>> Hi,
>> This cleans up and fixes fw stats aggregation.
>> Michal Kazior (4):
>>   ath10k: split wmi stats parsing
>>   ath10k: rename fw_stats related stuff
>>   ath10k: request fw_stats once on open
>>   ath10k: fix fw stats processing
> I didn't review these yet but I saw new warnings:
> drivers/net/wireless/ath/ath10k/debug.c: In function 'ath10k_fw_stats_fill':
> drivers/net/wireless/ath/ath10k/debug.c:540:5: warning: format '%lu' expects argument of type 'long unsigned int', but argument 5 has type 'size_t' [-Wformat]

Oh, I didn't see this one. I guess it should be %zu.

> drivers/net/wireless/ath/ath10k/wmi.c:1513: WARNING: else is not generally useful after a break or return

I'm aware of this one but the code looks nicer with the `else` to me though.


More information about the ath10k mailing list