[PATCH 5/5] ath10k: replace power up/down with reset callback

Michal Kazior michal.kazior at tieto.com
Mon Oct 13 01:25:17 PDT 2014

On 13 October 2014 10:01, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
> Michal Kazior <michal.kazior at tieto.com> writes:
>> The power up/down didn't make much sense any more
>> since hif_stop already stops the device
>> compeletely. The target lifecycle was never symmetric
>> so don't bother trying to make it look like it is
>> and expose a reset hif callback instead of power
>> up/down callbacks.
>> This removes redundant reset calls and thus makes
>> device boot/stop/recovery a bit faster.
>> Signed-off-by: Michal Kazior <michal.kazior at tieto.com>
> About this I'm not that sure. The reason why I wanted to have power_up()
> and power_down() is the case when we need to control the target power
> via a gpio line, which I anticipate we will need soon. If you remove
> these how could we control the gpio line?
> Wouldn't it be the same that you just make hif_power_up() do the same as
> hif_reset() and hif_power_down() doesn't do anything (for now)? Or am I
> missing something?

Hmm.. I guess that's fine as well. I'll rework it to keep power_up
(which will basically do reset) and power_down (nop for now).


More information about the ath10k mailing list