[PATCH 5/5] ath10k: replace power up/down with reset callback

Kalle Valo kvalo at qca.qualcomm.com
Mon Oct 13 01:01:07 PDT 2014

Michal Kazior <michal.kazior at tieto.com> writes:

> The power up/down didn't make much sense any more
> since hif_stop already stops the device
> compeletely. The target lifecycle was never symmetric
> so don't bother trying to make it look like it is
> and expose a reset hif callback instead of power
> up/down callbacks.
> This removes redundant reset calls and thus makes
> device boot/stop/recovery a bit faster.
> Signed-off-by: Michal Kazior <michal.kazior at tieto.com>

About this I'm not that sure. The reason why I wanted to have power_up()
and power_down() is the case when we need to control the target power
via a gpio line, which I anticipate we will need soon. If you remove
these how could we control the gpio line?

Wouldn't it be the same that you just make hif_power_up() do the same as
hif_reset() and hif_power_down() doesn't do anything (for now)? Or am I
missing something?

Kalle Valo

More information about the ath10k mailing list