[PATCH] ath10k: add the Rx rate in FW stats

Yeoh Chun-Yeow yeohchunyeow at gmail.com
Fri Mar 21 10:22:59 EDT 2014

> Unfortunately this isn't as simple as it seems.
> Stats are received via wmi_stats_event. This structure contains fields
> describing number of pdev/vdev/beer/bcn stat entries. All entries
> (structures) are appended in certain order after this header. This
> means if you change length of structure type you skew the calculation
> of all succeeding entries.
> IOW this means this patch breaks peer stats for 999.999.0.636.
> I'm quite positive wmi_pdev_stats is also broken. This implies vdev
> stats and peer stats position calculation is skewed in the first place
> and you get garbage.
> The main problem here is there are subtle yet crazy binary
> incompatibilities between these firmwares.
> The best way would probably be to implement wmi as an abstraction
> layer with completely different backends for different firmware
> branches/revisions. Otherwise you sign up for some pain..

Thanks for your explanation. I will definitely take a look on this if
I am able to figure out.

This patch seems work well with patch from Ben Greear on latest AP firmware.


More information about the ath10k mailing list