[PATCH v2] ath10k: add soft/hard firmware crash option to simulate_fw_crash

Kalle Valo kvalo at qca.qualcomm.com
Fri Mar 14 06:39:26 EDT 2014


Hi Marek,

Kalle Valo <kvalo at qca.qualcomm.com> writes:

> From: Marek Puzyniak <marek.puzyniak at tieto.com>
>
> Command WMI_FORCE_FW_HANG_CMDID is not supported in firmware 10.1.
> In order to have firmware crash simulation functionality also
> in firmware 10.1 driver can force firmware crash by performing not allowed
> operation. Driver can deliberately crash firmware when setting vdev param for
> vdev id out of range.  This patch introduces two keywords to simulate_fw_crash:
>
> 'soft' which will cause firmware crash that is recoverable
>        by warm firmware reset but supported only in main firmware.
> 'hard' which will cause firmware crash recoverable by cold
>        firmware reset, this option works for both firmwares.
>
> Commands to trigger firmware soft/hard crash:
>
> echo 'soft' > /sys/kernel/debug/ieee80211/phyX/ath10k/simulate_fw_crash
> echo 'hard' > /sys/kernel/debug/ieee80211/phyX/ath10k/simulate_fw_crash
>
> kvalo: use strncmp(), remove '\n' before checking the command and
> document how buf is null terminated
>
> Signed-off-by: Marek Puzyniak <marek.puzyniak at tieto.com>
> Signed-off-by: Kalle Valo <kvalo at qca.qualcomm.com>

can you please review my changes and check if they are ok?

-- 
Kalle Valo



More information about the ath10k mailing list