[PATCH] ath10k: don't allow stand alone monitor mode for non-AP firmware

Yeoh Chun-Yeow yeohchunyeow at gmail.com
Thu Apr 24 02:19:10 PDT 2014

On Thu, Apr 24, 2014 at 4:45 PM, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
> Yeoh Chun-Yeow <yeohchunyeow at gmail.com> writes:
>>>> +     if (ar->fw_version_build == 636) {
>>> Checking for firmware version in ath10k is a big no. For a functinality
>>> change like this you should add a new feature flag to enum
>>> ath10k_fw_features (and I need to then recreate the firmware image).
>> Should we just use the ATH10K_FW_FEATURE_WMI_10X?
> That's a bit dangerous if in the future there's a new firmware which
> doesn't have ATH10K_FW_FEATURE_WMI_10X but still doesn't support stand
> alone monitor mode.

Then, we may need to introduce the new feature flag.

But then I just wondering if the firmware 636 claimed to support STA
mode "well" but then not allowed to be bridged. This may cause
confusion to end user which is the best firmware for STA mode. FYI, AP
firmware has no such issue if using as STA mode and put into
promiscuous mode.


More information about the ath10k mailing list