[PATCH] ath10k: don't allow stand alone monitor mode for non-AP firmware

Kalle Valo kvalo at qca.qualcomm.com
Thu Apr 24 01:45:24 PDT 2014

Yeoh Chun-Yeow <yeohchunyeow at gmail.com> writes:

>>> +     if (ar->fw_version_build == 636) {
>> Checking for firmware version in ath10k is a big no. For a functinality
>> change like this you should add a new feature flag to enum
>> ath10k_fw_features (and I need to then recreate the firmware image).
> Should we just use the ATH10K_FW_FEATURE_WMI_10X?

That's a bit dangerous if in the future there's a new firmware which
doesn't have ATH10K_FW_FEATURE_WMI_10X but still doesn't support stand
alone monitor mode.

Kalle Valo

More information about the ath10k mailing list