[PATCH 3/3] ath10k: implement firmware IE container support

Kalle Valo kvalo at qca.qualcomm.com
Thu Sep 26 02:18:05 EDT 2013

Michal Kazior <michal.kazior at tieto.com> writes:

> On 26 September 2013 07:55, Kalle Valo <kvalo at qca.qualcomm.com> wrote:
>> Michal Kazior <michal.kazior at tieto.com> writes:
>>> Did you skip board file intentionally?
>> Yes, because my understanding is that the board file is not tied to any
>> particular firmware version. The board file should be specific to the
>> hardware configuration in use, or at least that's how it is with ath6kl.
> But the board file is not loaded at all for API 2. The api_1 variant
> requests 3 files and can result with up to 3 binaries loaded. api_n
> requests 1 file and can result with up to 2 binaries loaded.

Oops, that's clearly a bug. How did it even pass my tests without the
board file? I'll send v2 to fix that.

So my idea is that with API 2 we load only firmware-2.bin and board.bin
from user space. With API 1 we continue loading firmware.bin, otp.bin
(optional) and board.bin, just as before. And firmware-2.bin can contain
the old firmware.bin (mandatory) and otp.bin (optional) images.

I just realised that I'm missing a check that there really is a firmware
image inside firmware-2.bin, need to add that as well.

Kalle Valo

More information about the ath10k mailing list