[PATCH] ath10k: fix num_sends_allowed replenishing

Kalle Valo kvalo at qca.qualcomm.com
Fri Sep 20 01:06:50 EDT 2013


Michal Kazior <michal.kazior at tieto.com> writes:

> Recent ce_sendlist removal patch has broken
> num_sends_allowed incrementing. num_sends_allowed
> exceeded initial values and could overflow.
>
> This code was supposed to replenish
> num_sends_allowed for partial sendlist items (i.e.
> before final sendlist item from a sendlist was
> completed and could be processed by completion
> handlers).
>
> Fortunately it seems it cause any major breakage,
> yet.
>
> Signed-off-by: Michal Kazior <michal.kazior at tieto.com>

Doh, I broke this. Sorry about that.

Applied, but I changed the commit log. Especially notice the changes in
the last sentence:

commit 1073ab2e9b0d45f318052a3f3690405fc04eda75
Author: Michal Kazior <michal.kazior at tieto.com>
Date:   Wed Sep 18 15:22:17 2013 +0200

    ath10k: fix num_sends_allowed replenishing
    
    Commit e9bb0aa39 ("ath10k: delete struct ce_sendlist") broke
    num_sends_allowed incrementing. num_sends_allowed
    exceeded initial values and could overflow.
    
    This code was supposed to replenish
    num_sends_allowed for partial sendlist items (i.e.
    before final sendlist item from a sendlist was
    completed and could be processed by completion
    handlers).
    
    Fortunately it seems it did not cause any major breakage,
    yet.
    
    Signed-off-by: Michal Kazior <michal.kazior at tieto.com>
    Signed-off-by: Kalle Valo <kvalo at qca.qualcomm.com>

-- 
Kalle Valo



More information about the ath10k mailing list