[PATCH v4 2/2] ath10k: implement per-VDEV FW statistics

Kalle Valo kvalo at qca.qualcomm.com
Fri Sep 6 05:48:28 EDT 2013

Bartosz Markowski <bartosz.markowski at tieto.com> writes:

> The WMI_REQUEST_PEER_STAT command with latst ( FW
> can return per-VDEV statistics. Using debugfs we can fetch this info now.
> This is a backward compatible change. In case of older FW the VDEV
> statistics are simply not returned.
> Signed-off-by: Bartosz Markowski <bartosz.markowski at tieto.com>
> ---


>  		for (i = 0; i < num_peer_stats; i++) {
> -			peer_stats = (struct wmi_peer_stats *)tmp;
> +			peer_stats = (struct wmi_peer_stats_common *)tmp;

You still have the evil cast here :)

(Evil here meaning that that you make the implicit assumption that _v1
and _v2 start with the _common struct.)

Let me send v5 and you can review that before I commit.

Kalle Valo

More information about the ath10k mailing list