[aiaiai PATCH v3 09/12] email-test-patchset: automatically obtain a base commit to test against

[Keller, Jacob E]

> -----Original Message-----
> From: aiaiai [mailto:aiaiai-bounces at lists.infradead.org] On Behalf Of
> Artem Bityutskiy
> Sent: Friday, February 07, 2014 2:47 AM
> To: The Aiaiai Mailing List
> Subject: Re: [aiaiai PATCH v3 09/12] email-test-patchset: automatically
> obtain a base commit to test against
> 
> On Fri, 2014-02-07 at 12:36 +0200, Artem Bityutskiy wrote:
> > From: Jacob Keller <jacob.e.keller at intel.com>
> >
> > In our environment, a queue of patches is used. Often, developers will
> > submit a v2 of a patch already in the queue before the maintainer can
> > "pop" this patch off the queue. This function setup here enables
> > determining if a patch with the same canonical subject is already
> > applied to the tree. A special parameter "base" is used to prevent going
> > back before the "published" upstream branch of the tree.
> 
> In general, I am find to add this kind of smartness to the project. This
> makes sense.
> 
> > This enables aiaiai to be smart enough to figure out when a patch should
> > be tested against the tip of queue, or against the parent of a previous
> > version. This relies on new patch versions having identical canonical
> > subject lines, though. (Equivalent except for the [... PATCH ...]
> > prefix(es)
> 
> But it sounds that this should be a feature of 'aiaiai-test-patchset',
> as this is not really specific to the e-mail front-end.
> 
> I sounds to me as this would need to be a separate option of
> 'aiaiai-test-patchset'.
> 
> And 'aiaiai-email-test-patchset' should just pass this option to
> 'aiaiai-test-patchset' if it is present in the config file.
> 
> I also think this option should be documented a bit. I guess I need to
> re-structure the docs and move e-mail front-end description to
> doc/email/, and then we could add a piece of description for this
> feature there.
> 
> How does this sound?
> 

It sounds fine, but I found adding this to the pre-caller of test-patchset was much simpler, as I can just change the sha1id that I pass to test-patchset.

It could work inside the test-patchset as well... I am not certain exactly how easy it would be to transplant into test-patchset, but making it more general is fine with me :)

Regards,
Jake

> --
> Best Regards,
> Artem Bityutskiy
> 
> 
> _______________________________________________
> aiaiai mailing list
> aiaiai at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/aiaiai