[aiaiai PATCH v3 09/12] email-test-patchset: automatically obtain a base commit to test against

Artem Bityutskiy dedekind1 at gmail.com
Fri Feb 7 02:46:33 PST 2014


On Fri, 2014-02-07 at 12:36 +0200, Artem Bityutskiy wrote:
> From: Jacob Keller <jacob.e.keller at intel.com>
> 
> In our environment, a queue of patches is used. Often, developers will
> submit a v2 of a patch already in the queue before the maintainer can
> "pop" this patch off the queue. This function setup here enables
> determining if a patch with the same canonical subject is already
> applied to the tree. A special parameter "base" is used to prevent going
> back before the "published" upstream branch of the tree.

In general, I am find to add this kind of smartness to the project. This
makes sense.

> This enables aiaiai to be smart enough to figure out when a patch should
> be tested against the tip of queue, or against the parent of a previous
> version. This relies on new patch versions having identical canonical
> subject lines, though. (Equivalent except for the [... PATCH ...]
> prefix(es)

But it sounds that this should be a feature of 'aiaiai-test-patchset',
as this is not really specific to the e-mail front-end.

I sounds to me as this would need to be a separate option of
'aiaiai-test-patchset'.

And 'aiaiai-email-test-patchset' should just pass this option to
'aiaiai-test-patchset' if it is present in the config file.

I also think this option should be documented a bit. I guess I need to
re-structure the docs and move e-mail front-end description to
doc/email/, and then we could add a piece of description for this
feature there.

How does this sound?

-- 
Best Regards,
Artem Bityutskiy




More information about the aiaiai mailing list