[PATCH 5/5] Switch to dash when possible
Keller, Jacob E
jacob.e.keller at intel.com
Thu Feb 6 13:14:37 PST 2014
On Thu, 2014-02-06 at 09:11 +0200, Artem Bityutskiy wrote:
> On Wed, 2014-02-05 at 21:03 +0000, Keller, Jacob E wrote:
> > Series looks good, thanks.
> > Only comment I have.. is that if we only support POSIX, shouldn't be be
> > using "/bin/sh" for our shell line at the top?
> This is exactly what we do in all the scripts - we use /bin/sh because
> we do not care about what is the system's shell.
> At some point I tested aiaiai even with ksh - worked fine.
> BTW, you tend to use [[ and == which I fix up in your patches. So far
> all the uses were easy to change with simple s/[[/]/ and s/==/=/. I.e.,
> there was no pattern matching, nothing like this.
Actually, I should have already swapped these from [ to [[ in my patch
set. Sorry if I had not. Thanks for cleaning it up. You discussed this
before. Generally, from what I had read, [[ was better for a few
reasons, but it makes sense not to rely on non portable things when
More information about the aiaiai