[PATCH 5/5] Switch to dash when possible

Artem Bityutskiy dedekind1 at gmail.com
Wed Feb 5 23:11:03 PST 2014


On Wed, 2014-02-05 at 21:03 +0000, Keller, Jacob E wrote:
> Series looks good, thanks.

Thanks!

> Only comment I have.. is that if we only support POSIX, shouldn't be be
> using "/bin/sh" for our shell line at the top?

This is exactly what we do in all the scripts - we use /bin/sh because
we do not care about what is the system's shell.

At some point I tested aiaiai even with ksh - worked fine.

BTW, you tend to use [[ and == which I fix up in your patches. So far
all the uses were easy to change with simple s/[[/]/ and s/==/=/. I.e.,
there was no pattern matching, nothing like this.

-- 
Best Regards,
Artem Bityutskiy




More information about the aiaiai mailing list