[PATCH] xusbatm.c - Fix usb_intf_has_ep() loops and add altsetting parameter

Duncan Sands duncan.sands at math.u-psud.fr
Fri Nov 18 07:08:37 EST 2005


Hi Aurelio,

> I'm testing xusbatm.c with Zyxel 630 and I need change usb_intf_has_ep().

probably you are the only person on the planet using this :)

> - Fix: endpoit loop use 'i' and not 'j'

You are right.

> - Fix: altsetting loop don't use 'i'

Also correct.

> 		This fix output a ¿warning? at make.
> 
> - ¿ & USB_ENDPOINT_NUMBER_MASK ?
> 		I need delete it to find ep... 

I've changed things so that you can provide endpoint numbers with or without
the direction bit - they are treated the same.

> - I add too a altsetting parameter, copy&paste, and a call to usb_set_interface().
> 
> 
> I'm connect whit it now.
> 
> More work is need but I don't know what do by now...
> 	... If a use altsetting parameter, why test all altsetting?...

The problem with altsetting, is that you really need two: one for tx, one for rx
(because the tx and rx endpoints may be on different interfaces, each of which
needs an altsetting).  I will try to come up with something reasonable...

D.



More information about the Usbatm mailing list