[PATCH: usbatm_15_05_05] usbatm_usb_probe() bugfix.

Stanislaw W. Gruszka stf_xl at wp.pl
Fri May 27 10:51:02 EDT 2005


Hi Duncan,

It seems that Your modified patch have a new bug  :( 
If allocation: 

buffer = kmalloc(channel->buf_size, GFP_KERNEL); 

fail, then the urb->transfer_buffer will not be initialized,
but the code:

fail_free:
	for (i = 0; i < num_rcv_urbs + num_snd_urbs; i++) {
		if (instance->urbs[i])
			kfree(instance->urbs[i]->transfer_buffer);
		usb_free_urb(instance->urbs[i]);
	}

will try to free it. 

--
Thanks and regards,
Staszek Gruszka




More information about the Usbatm mailing list