[linux-usb-devel] [PATCH 1/5] USB ATM: new usbatm core

[Oliver Neukum]

Am Donnerstag, 12. Mai 2005 22:51 schrieb Roman Kagan:
> On Thu, May 12, 2005 at 06:56:34PM +0200, Oliver Neukum wrote:
> > static inline int usbatm_submit_urb(struct urb *urb)
> > 
> > You'll enter this with irqs off and will leave it with irqs on.
> 
> Mind elaborating a bit?  I can see that we may enable irqs with
> spin_unlock_irq() on the error path, but how do we enter
> usbatm_submit_urb() with irqs off?  It's only called from tasklets and
> user context.  Am I missing anything obvious?

Sorry, I thought you called it directly from the timer.

	Regards
		Oliver