updated patch with throttling

Duncan Sands baldrick at free.fr
Fri Mar 25 08:26:43 EST 2005


On Fri, 2005-03-25 at 16:21 +0300, Roman Kagan wrote:
> On Fri, Mar 25, 2005 at 01:51:28PM +0100, Duncan Sands wrote:
> > mightn't you need to call usb_clear_halt somewhere?
> 
> Hmm, maybe...  On urb->status == -EPIPE.  BTW in the proposed change the
> urb status is propagated to the tasklet, so it can do better handling of
> completion errors too.  Most natural seems to be to update atm stats
> (now we only update it on decoding errors), and probably do some
> throttling too.

The big problem with usb_clear_halt is that it needs to be called
in process context.  This may have a big impact on the design, which
is why I'm mentioning it.

Ciao,

D.




More information about the Usbatm mailing list