[RFC][PATCH] Very basic sysfs support for ATM devices
rkagan at mail.ru
Wed Jan 19 15:19:38 EST 2005
On Wed, 2005-01-19 at 20:37 +0100, Aurelio Arroyo wrote:
> > 2) pppd with rp-pppoe plugin, when started before the ADSL link is
> > negotiated, times out to receive PADO and never retries, so I had to put
> > a big delay before starting it up to allow for link to be established
> > first.
> If I understand you, I only can repeat your words "the right solution is to
> create the ATM device only when it's usable" ;^)
No, that's a different story. In fact, the patch to cxacru.c I posted
the other day (still not commented by anyone, hint) was applied here
too, so the ATM device was created only when the modem was fully
initialised. At that time it's definitely usable.
> Delay it until line sync end?
No, you don't want the ATM device to disappear if someone pulls out the
phone line jack. That's what atm_dev->signal is for.
The problem I'm seeing is in pppd: if it fails to establish a
connection, it should either retry or exit with a failure code. Instead
it's going to sleep forever, and that IMO is a bug.
More information about the Usbatm