speedtch usbatm.h,1.4,1.5 usbatm2.c,1.13,1.14

Roman Kagan rkagan at mail.ru
Mon Feb 7 13:01:58 EST 2005


  Hi Duncan,

On Mon, Feb 07, 2005 at 06:43:34PM +0100, Duncan Sands wrote:
> I've been testing the synchronous version and it seems to work fine, so...

Please don't get me wrong: I didn't mean it didn't work.  My arguments
were (and still are :) :

On Wed, Feb 02, 2005 at 11:23:50PM +0300, Roman Kagan wrote:
>  1) it isn't any more complex than the synchronous one
> 
>  2) the requirements to the .cleanup method in the async case are
>     obvious from the interface, unlike the obscure requirements to the
>     .heavy_init to be interruptible and quick to exit in the sync case
> 
>  3) if we ever come to publish some info from the subdrivers in sysfs,
>     the .cleanup will be a must (as the only way to handle the
>     degenerate case of open files in sysfs while removing the device)

Don't you agree they are valid?

Cheers,
  Roman.



More information about the Usbatm mailing list