[PATCH] report that OAM is not supported

Duncan Sands baldrick at free.fr
Tue Apr 26 04:02:40 EDT 2005

> +	u32 vci, cached_vci = 0;
> +       u16 vpi, cached_vpi = 0;

Don't you only need 16 bits for the vci and 8 bits for the
vpi?  On the other hand, won't the code be more efficient if
they are both just "unsigned"?  Finally, the ATM code uses
short for vpi and int for vci (and so do we in
struct usbatm_vcc_data and usbatm_find_vcc), so why not just
use those here?



More information about the Usbatm mailing list