usbatm cxacru.c,1.27,1.28

Roman Kagan rkagan at
Fri Apr 22 06:07:45 EDT 2005

On Fri, Apr 22, 2005 at 11:33:50AM +0200, Duncan Sands wrote:
> > +	cancel_delayed_work(&instance->poll_work);
> Shouldn't this be cancel_rearming_delayed_work?  (Fairly
> new routine, may not be in your kernel).

Yes, I've put in cancel_rearming_delayed_work() at first, but it turned
out not to be in 2.6.11, so I've changed to simply cancel_delayed_work()
followed by flush_scheduled_work(), which is obviously insufficient.

I've replaced it with the loop similar to that in
cancel_rearming_delayed_workqueue(), which isn't exported in 2.6.12-rc2
for some reason (only cancel_rearming_delayed_work() is), so that when
we switch to the private workqueue it'll be a matter of replacing a
couple of function calls.

Thanks for pointing it out,

More information about the Usbatm mailing list