speedtch testatm.c,1.4,1.5

Roman Kagan rkagan at mail.ru
Sun Apr 10 12:29:43 EDT 2005


On Fri, Apr 08, 2005 at 02:18:42PM +0200, Duncan Sands wrote:
> (1) I set the interface data to the usbatm_data for all interfaces.
> That way, a disconnect on any one of them will cause unbind to be
> called.

I just realized that I can't find a confirmation for this in the code.

It seems that the following patch needs to be applied for this to be
true.

--- testatm.c	7 Apr 2005 22:16:18 -0000	1.5
+++ testatm.c	10 Apr 2005 16:22:16 -0000
@@ -248,6 +248,8 @@ static int claim_bind(struct usbatm_data
 				release_interfaces(usb_dev, i);
 				return ret;
 			}
+
+			usb_set_intfdata(cur_intf, usbatm);
 		}
 	}
 

Still, unless the intfdata can contain nonzero garbage if not set
explicitly, I don't see how this can lead to the problem you see.

Roman.



More information about the Usbatm mailing list