[RFC] [PATCH] usbatm.[ch]: multiple changes

[matthieu castet]

matthieu castet wrote:
> So I believe this 2 problem are linked to the modem and they were masked 
> by the adi driver. I agree that they shouldn't happen. I will try to do 
> some test and ask people to do some. I will also try the windows driver 
> and see if it produce errors in bulk mode.
> 
Some first stat with bulk mode and current cvs version (not roman patch) 
the number of rcv urb were 4
64 seem to be the best for rcv_buf_size.

I attach the script, if somebody want to test with its modem.

The test consit of downloading a file during 2 minute. The file is 
located on my provider ftp, so the throughput should be maximal.


trying with rcv_buf_size=32
size : 92 knoppix-MiB-PPC-alpha-2e.iso
AAL5: tx 79 ( 0 err ), rx 94 ( 0 err, 0 drop )
trying with rcv_buf_size=64
size : 65644 knoppix-MiB-PPC-alpha-2e.iso
AAL5: tx 24678 ( 0 err ), rx 46413 ( 360 err, 0 drop )
trying with rcv_buf_size=128
size : 45468 knoppix-MiB-PPC-alpha-2e.iso
AAL5: tx 17803 ( 0 err ), rx 32179 ( 392 err, 0 drop )
trying with rcv_buf_size=256
size : 23300 knoppix-MiB-PPC-alpha-2e.iso
AAL5: tx 3162 ( 0 err ), rx 16548 ( 28 err, 0 drop )
trying with rcv_buf_size=512
size : 25664 knoppix-MiB-PPC-alpha-2e.iso
AAL5: tx 3030 ( 0 err ), rx 18216 ( 41 err, 0 drop )
trying with rcv_buf_size=1024
size : 1640 knoppix-MiB-PPC-alpha-2e.iso
AAL5: tx 704 ( 0 err ), rx 1214 ( 2 err, 0 drop )
-------------- next part --------------
#! /bin/bash
for i in $(seq 5 10)
do 
	echo trying with rcv_buf_size=$((1<<$i))
	modprobe usbatm num_rcv_urbs=4 rcv_buf_size=$((1<<$i))
	modprobe ueagle-atm iso=0
	while true
	do
		grep operat /proc/driver/ueagle-atm/*
		if [ $? = 0 ]
		then
			break
		fi
		sleep 3
	done
	atmarp -s x 0.8.36 null

	wget ftp://ftp.free.fr/mirrors2/knoppix-mib.org/knoppix-MiB-PPC-alpha-2e.iso 2>&1 & 
	sleep 2m
	killall wget
	echo
	echo size : $(du knoppix-MiB-PPC-alpha-2e.iso)
	rm knoppix-MiB-PPC-alpha-2e.iso 
	cat /proc/net/atm/ueagle-atm\:0
	cat cat /proc/driver/ueagle-atm/*

	atmarp -d x
	rmmod ueagle-atm
	rmmod usbatm
done