[RFC] [PATCH] usbatm.[ch]: multiple changes

[matthieu castet]

Hi Roman,
Roman Kagan wrote:
> On Thu, Mar 31, 2005 at 07:55:49PM +0200, matthieu castet wrote:
> 
>>It don't work very well : 170 kB/s instead of 700kB/s
> 
> 
> So it didn't crash - that's already a good news :)
> 
> 
>>I was using 503 for the buff size.
> 
> 
> Hmm, if you use 1007 bytes == 19 cells per iso frame (you don't use
> padding, do you?) and want 16 iso frames per urb you need buffer size of
> 19 * 16 = 304.  503 shouldn't be a problem too, however, from the
> aesthetic POV I'd suggest a multiple of iso frame size, say 494 or 513.
well I need to investigate, I set it to 304 and it work well :)

> 
> 
>>There lot's of
>>Mar 31 19:47:14 localhost kernel: /home/mat/driver/usbatm/usbatm.c: 
>>usbatm_check_usb_errcode: channel 0xf58912a0, errcode -84
> 
> 
> Yep, that's the notorious -EILSEQ you were seeing before...
There no need for the attached patch as -EILSEQ  seems to appear only 
when the modem failed to fill to urb (so only when the modem send 
nothing)...
Also because you mix in your error count urb_submit and urb->status the 
counter is always 0 or 1...

Why usbatm_check_usb_errcode is dbg not vdbg : it generate lot's of log...



cheers

Matthieu