[PATCH] kernel: Mediatek: fix EEE registers init

Qingfang Deng dqfext at gmail.com
Sun Mar 30 19:00:08 PDT 2025


Hi Daniel,

On Fri, Mar 14, 2025 at 9:56 AM Qingfang Deng <dqfext at gmail.com> wrote:
>
> Hi Daniel,
>
> On Fri, Mar 14, 2025 at 3:42 AM Daniel Golle <daniel at makrotopia.org> wrote:
> >
> > Hi Qingfang,
> >
> > I've been testing EEE support on MT7986 as well as MT7988 with your
> > patches on top of OpenWrt's Linux 6.6.82.
> >
> > I noticed that while the LPI timer of the MT753x DSA switch ports is
> > 30us by default it is deplayed as 0us on the SoC's Ethernet ports, which
> > seems wrong... I guess this should be fixed as well.
>
> This patch sets the default to 1000 us. Does it still read 0 us on your end?

I've been testing this patch on my TP-Link XDR8086 for the past two
weeks without any issues. Running ethtool --show-eee eth1 correctly
reports the default LPI timer value (1000 us).

Additionally, there's a related issue on GitHub (#18219) that has been
open for three weeks, so I hope this patch gets merged soon.

If the current backport approach is not preferred, an alternative
would be to revert it first and then discuss the proper way forward
with Russell King, who has already accepted my upstream patch.

Regards,
Qingfang



More information about the openwrt-devel mailing list