[PATCH] mvebu: armada 370: dts: fix the crypto engine

[Daniel González Cabanelas]

Hi Hauke,

El lun, 5 abr 2021 a las 14:55, Hauke Mehrtens (<hauke at hauke-m.de>) escribió:
>
> On 4/4/21 11:06 PM, Daniel González Cabanelas wrote:
> > The crypto engine in Armada 370 SoCs is currently broken. It can be
> > checked installing the required packages for testing openssl with hw
> > acceleration:
> >
> >    opkg install openssl-util
> >    opkg install kmod-cryptodev
> >    opkg install libopenssl-devcrypto
> >
> > After configuring /etc/ssl/openssl.cnf to let openssl use the crypto
> > engine for digest operations, and performing some checksums..
> >
> >    md5sum 10M-file.bin
> >    openssl md5 10M-file.bin
> >
> > ...we can see they don't match.
> >
> > There might be an alignment or size constraint issue caused by the
> > idle-sram area.
> >
> > Use the whole crypto sram and disable the idle-sram area to fix it. Also
> > disable the idle support by adding the broken-idle property to prevent
> > accessing the disabled idle-sram.
> >
> > We don't care about disabling the idle support since it is already broken
> > in Armada 370 causing a huge performance loss because it disables
> > permanently the L2 cache. This was reported in the Openwrt forum and
> > elsewhere by Debian users with different board models.
>
> Is the L2 cache disabled without or with this patch?

The L2 Aurora cache is always disabled without the patch.

With this patch it is enabled, therefore it fixes the crypto engine
and also the L2 cache issue. The side effect is a disabled idle
support which can be considered broken anyway.

>
> >
> > Signed-off-by: Daniel González Cabanelas <dgcbueu at gmail.com>
>
> Could you send this also to the upstream Linux maintainers, I would like
> to get their opinion on this and if this is correct it should also go
> into upstream Linux.
>
Sure. I'll wait a bit to see if Thomas Petazzoni is aware of the
problem replying to this mail.

> Hauke

Thank you
Daniel