[OpenWrt-Devel] [PATCH] build, imagebuilder: Do not require libncurses-dev

[Paul Spooren]

Hi Sven,

thanks for testing!

You're right, I tried on a testing VM and had the same issue. I'm afraid 
I had libncurses-dev and libncurses5-dev installed but only removed one 
while testing :(

It should be fixed via https://github.com/openwrt/openwrt/pull/3098

Best,
Paul

On 6/8/20 5:53 PM, Sven Roederer wrote:
> Am Dienstag, 14. April 2020, 23:14:47 CEST schrieb Paul Spooren:
>> The buildroot and SDK both require `libncurses-dev` to be installed on
>> the system, however the ImageBuilder uses precompiled binaries.
>>
>> This patch changes the prerequirements checks to skip the
>> `libncurses-dev` part if running as ImageBuilder.
>>
> Hi Paul,
>
> I gave this today a test on my spare computer, but it still complained about
> the missing libncurses.
> I tested with snapshot imagebuilder (r13519-8a858363b0) with just calling
> "make image"
>
> Any ideas?
>
> Sven
>
>> Signed-off-by: Paul Spooren <mail at aparcar.org>
>> ---
>>   include/prereq-build.mk | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/include/prereq-build.mk b/include/prereq-build.mk
>> index 830a9eff9a..72fb6ad97a 100644
>> --- a/include/prereq-build.mk
>> +++ b/include/prereq-build.mk
>> @@ -51,10 +51,12 @@ $(eval $(call TestHostCommand,working-g++, \
>>   		g++ -x c++ -o $(TMP_DIR)/a.out - -lstdc++ && \
>>   		$(TMP_DIR)/a.out))
>>
>> +ifndef IB
>>   $(eval $(call TestHostCommand,ncurses, \
>>   	Please install ncurses. (Missing libncurses.so or ncurses.h), \
>>   	echo 'int main(int argc, char **argv) { initscr(); return 0; }' | \
>>   		gcc -include ncurses.h -x c -o $(TMP_DIR)/a.out - -lncurses))
>> +endif
>>
>>   ifeq ($(HOST_OS),Linux)
>>     zlib_link_flags := -Wl,-Bstatic -lz -Wl,-Bdynamic
>
>
>

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel