[PATCH] build/prereq: requie make 4.1 or later
Petr Štetiar
ynezz at true.cz
Mon Dec 14 02:38:52 EST 2020
Paul Spooren <mail at aparcar.org> [2020-12-12 21:17:02]:
Hi,
> FS#2086 "IS_TTY in the makefile is broken" reports flawed detection of
> stdout piping to a file. The issue describes how e.g. terminal color
> codes and up in log files if running make like `make > log.txt`.
>
> The proposed solution uses the make variable "MAKE_TERMOUT", which was
> introduced in make 4.1. All major distributions seem to updated to 4.1
> or later, so this ideally dosn't break anything.
BTW it would be nice to update the README as well. I think, that it would
make sense to postpone this by a few days, right after the 20.12 is branched.
I'm holding the gcc6+ patch[1] for the similar reasons.
1. https://patchwork.ozlabs.org/project/openwrt/patch/20191112200129.19396-1-ynezz@true.cz/
Cheers,
Petr
More information about the openwrt-devel
mailing list