[PATCH] build/prereq: requie make 4.1 or later

Felix Fietkau nbd at nbd.name
Sun Dec 13 10:48:52 EST 2020


On 2020-12-13 12:35, Hauke Mehrtens wrote:
> On 12/13/20 8:17 AM, Paul Spooren wrote:
>> FS#2086 "IS_TTY in the makefile is broken" reports flawed detection of
>> stdout piping to a file. The issue describes how e.g. terminal color
>> codes and up in log files if running make like `make > log.txt`.
>> 
>> The proposed solution uses the make variable "MAKE_TERMOUT", which was
>> introduced in make 4.1. All major distributions seem to updated to 4.1
>> or later, so this ideally dosn't break anything.
> 
> Ubuntu uses make >= 4.1 since 16.04 LTS. (all supported versions)
> https://distrowatch.com/table.php?distribution=ubuntu
> 
> RedHat 8 uses make 4.2.1, RedHat 7 uses 3.82 which would be too old.
> https://distrowatch.com/table.php?distribution=redhat
> 
> Debian uses make >= 4.1 since 9 stretch (oldstable)
> https://distrowatch.com/table.php?distribution=debian
> 
> Please check what is used on MacOS with Felix or Kevin.
macOS still ships an ancient and broken GNU make 3.81 version, which
forces you to install a newer version via homebrew, even without this
patch. No objection from me on raising the minimum version.

- Felix



More information about the openwrt-devel mailing list