[luci PATCH 05/13] luci-mod-status: use the new ubus dsl metrics
Andre Heider
a.heider at gmail.com
Fri Dec 11 08:26:23 EST 2020
On 11/12/2020 13:11, Jo-Philipp Wich wrote:
> Hi,
>
>> This is significantly faster.
>
> great work! I like it :)
>
> Minor nitpick below.
>
>
>
>> [...]
>> -var callLuciDSLStatus = rpc.declare({
>> - object: 'luci-rpc',
>> - method: 'getDSLStatus',
>> +var call_dsl_metrics = rpc.declare({
>> + object: 'dsl',
>> + method: 'metrics',
>> expect: { '': {} }
>> });
>
> Please keep the camel case notation to align with the other RPC method
> declarations in the tree, so `s/call_dsl_metrics/callDSLMetrics/g`
Alright, fixed locally!
Thanks,
Andre
More information about the openwrt-devel
mailing list