[OpenWrt-Devel] [PATCH fwtool 0/8] fwtool improvements

Petr Štetiar ynezz at true.cz
Wed Oct 23 06:53:31 EDT 2019


Hi,

this patches moves fwtool out of tree into separate project, adds bunch of
fixes, GitLab CI support and some unit tests as a bonus.

Cheers,

Petr

Petr Štetiar (8):
  refactor into separate Git project
  convert into CMake project
  iron out extra compiler warnings
  add initial GitLab CI support
  add cram based unit tests
  crc32: add missing stdint.h dependency
  fix possible copy of null buffer and validation of unitialized header
  fix possible garbage in unitialized char* struct members

 .gitignore                      |   3 ++
 .gitlab-ci.yml                  |  14 +++++
 CMakeLists.txt                  |  14 +++++
 Makefile                        |  47 -----------------
 src/crc32.h => crc32.h          |   2 +
 src/fwimage.h => fwimage.h      |   0
 src/fwtool.c => fwtool.c        |  39 ++++++++++----
 tests/CMakeLists.txt            |   4 ++
 tests/artifacts/key-build.ucert | Bin 0 -> 516 bytes
 tests/artifacts/metadata.json   |   1 +
 tests/cram/CMakeLists.txt       |  22 ++++++++
 tests/cram/test_crc32.t         |  12 +++++
 tests/cram/test_fwtool.t        |  90 ++++++++++++++++++++++++++++++++
 tests/test-crc32.c              |  26 +++++++++
 src/utils.h => utils.h          |   0
 15 files changed, 216 insertions(+), 58 deletions(-)
 create mode 100644 .gitignore
 create mode 100644 .gitlab-ci.yml
 create mode 100644 CMakeLists.txt
 delete mode 100644 Makefile
 rename src/crc32.h => crc32.h (98%)
 rename src/fwimage.h => fwimage.h (100%)
 rename src/fwtool.c => fwtool.c (92%)
 create mode 100644 tests/CMakeLists.txt
 create mode 100644 tests/artifacts/key-build.ucert
 create mode 100644 tests/artifacts/metadata.json
 create mode 100644 tests/cram/CMakeLists.txt
 create mode 100644 tests/cram/test_crc32.t
 create mode 100644 tests/cram/test_fwtool.t
 create mode 100644 tests/test-crc32.c
 rename src/utils.h => utils.h (100%)


_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel


More information about the openwrt-devel mailing list