[OpenWrt-Devel] [PATCH v4 3/5] ath79: add support for Netgear WNR2000 v3

[Michal Cieslakiewicz]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On Tue, 13 Aug 2019 13:03:55 +0200
"Adrian Schmutzler" <mail at adrianschmutzler.de> wrote:

> > -----Original Message-----
> > From: openwrt-devel
> > [mailto:openwrt-devel-bounces at lists.openwrt.org] On Behalf Of
> > Michal Cieslakiewicz Sent: Dienstag, 13. August 2019 10:52 To:
> > openwrt-devel at lists.openwrt.org Cc: Adrian Schmutzler
> > <mail at adrianschmutzler.de> Subject: [OpenWrt-Devel] [PATCH v4 3/5]
> > ath79: add support for Netgear WNR2000 v3
> > 
> > This patch adds ath79 support for Netgear WNR2000v3.
> > Router was previously supported by ar71xx target only.
> > Note: this is a 4_32 device with limited upgrade capabilities.  
> 
> Sorry, found two things again.
> 
> > +	ucidef_set_led_default "wan-green" "WAN (green)"
> > "netgear:green:wan" "0"  
> 
> Can this be done with default-state = off in DTS?
> 

Probably copy-paste from ar71xx files. Tested on WNR2000v3, setting
state to off is not needed at all, so another one line less in v5. 

> > +&gpio {
> > +	status = "okay";
> > +};  
> 
> I think this is not required as gpio is not disabled. But please test.
> 

Again, WNR2000v3 confirms what you suggest, gpio is enabled by default.
Marked fo removal in v5.

> As those changes are minor, maybe wait with a v5 until you receive
> feedback from someone else, then ...
> 
> Best
> 
> Adrian

Fair enough, in the meantime I will proceed gradually with testing
pre-v5 on all 4 router models...

Cheers
Michal
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEi7ylFMzTSbpOuOZIHU8//LdGKWsFAl1SpOEACgkQHU8//LdG
KWsRMhAAj8xLox2VKzcJ+MLoDShgnL56tAEqzm9sLDIuhFxWfbnM5CsKtB4Q+fRS
K/9Da3JIe8LqNmom3KYPX4l8mXJYLw1fUbqte2miZVC8IfIZYlPp048JsYQvIuCi
kksH8shFigNxUz6u5pazhyOeY7zjR9f5mb/6CAMLigjt5lEwrL3NbL1iCveFaRFF
rlEYeEWoK+GLHFXCKCMAZIo3QL25OG+pkuIV2RgPuXBzmeQnClWbGKhbuzrqoF7Y
wW4GMdLgj/HG3v5HbzWiPXVjZElI1ZPjaUSTKE4625wA6V5AQ6vbTmhSL5BxjPky
j3Fb/4klOUv0bea9JcfOe0IX9sCs+VNFbE9yeI8FCmcEN4h48qbtihQFCwfcqT7E
VpH6pIWBXBJ8K1ZxYlnBLW6X5nQy++coi7O7K3BsPEimd8hHr/DIeAMJC4zprwbE
n05Yqr3gk9kJ6D/YQW1gUxzAKREV30YYD/xx3lML9ypnb226zdxPrnhj+0+hp0zj
tXY3GfXM48yWivhGNBn8PX5Pb6PPBaJYyOKGox06y8PXjgyUFSITJymn9ZvjK5my
1Zv68gR5TIaJf9LZ0+dsA8zXCle0PxkImsS902/pJfIG7QgqtI7OYaW7ZrCM0D4I
keg9WKtuA95cdZrsLIozHJItGNLh1gOmY1fWPeGZsCq2jltbngw=
=ouzk
-----END PGP SIGNATURE-----
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel