[OpenWrt-Devel] [PATCH v3 3/5] ath79: add support for Netgear WNR2000 v3

[Michal Cieslakiewicz]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On Mon, 12 Aug 2019 14:22:52 +0200
"Adrian Schmutzler" <mail at adrianschmutzler.de> wrote:

> Hi, comments below, too:
> 
> > diff --git
> > a/target/linux/ath79/base-files/etc/hotplug.d/firmware/10-ath9k-eeprom
> > b/target/linux/ath79/base-
> > files/etc/hotplug.d/firmware/10-ath9k-eeprom index
> > ec597dd1d4..747c1aab58 100644 ---
> > a/target/linux/ath79/base-files/etc/hotplug.d/firmware/10-ath9k-eeprom
> > +++
> > b/target/linux/ath79/base-files/etc/hotplug.d/firmware/10-ath9k-eeprom
> > @@ -165,6 +165,7 @@ case "$FIRMWARE" in winchannel,wb2000)
> > ath9k_eeprom_extract "art" 20480 1088 ;;
> > +	netgear,wnr2000-v3|\
> >  	netgear,wnr612-v2|\
> >  	on,n150r|\
> >  	pcs,cap324|\  
> 
> You are using mtd-cal-data in DTS for this device. Does this work?
> Then you should be able to remove the entries in 10-ath9k-eeprom.
> Otherwise, remove mtd-cal-data. Based on the result, you may want to
> change the other devices accordingly.
> 
> > +&pcie {
> > +	status = "okay";
> > +
> > +	ath9k: wifi at 0,0 {
> > +		compatible = "pci168c,002e";
> > +		reg = <0x0000 0 0 0 0>;
> > +		mtd-mac-address = <&art 0x0>;
> > +		mtd-mac-address-increment = <1>;
> > +		mtd-cal-data = <&art 0x1000>;  
> 
> Despite comments from above, we have the same situation regarding MAC
> address here. Is the MAC address read via cal-data already? Then act
> as described in the previous patch annotation.
> 

Hi Adrian,

Thanks - I've just tested it on WNR2000v3 and apparently
10-ath9k-eeprom is the working solution. So mtd-cal-data will be
removed in v4 patches from all WNR* DTSes.

> > +	};
> > +};
> > +
> > +&uart {
> > +	status = "okay";
> > +};
> > +
> > +&gpio {
> > +        status = "okay";
> > +};  
> 
> Leading spaces here. Change to tabs. And maybe check all your files,
> as I just found this by accident and did not look everywhere ...
>

Yep, I've missed it... Fixed in v4.

Cheers
Michal
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEi7ylFMzTSbpOuOZIHU8//LdGKWsFAl1Rd8cACgkQHU8//LdG
KWt2yg//T291n1+luMfAaldqSDWJ8gLIkRCzxsI4S9uKNUCzNFzp0L22pu9/a/9y
EmcXJVhUbLx0iKO3HBKQKMmnUrNy12bJP6FFQQgRbaLyoawRI1rqOirpQjYSP31p
pde+KVEmxL87RjGZP6yhN1hb8QMHpZuHrHOI3BWI4XvQtGlpHMmzz82dn4na/u+K
CQ1SZf4w3UPFSUt17/ujAFzec++fRoDCYy9PKPVLPcjuY6Th8KuA2f0+WeJefGQg
z+D05HrKPFz8iXqPXLU+MAe76c4ZMYvpT6c9jalDCzte9y6H3CWpDrzPz0hTdr/a
qNMLds8weDZoR+Db0+vG21qX1f0IzbQ0pnoS8Nc/mEoALZEpZWuEOzwI9VMG/dqp
k1PpVRcInNr+FkLlOu2a5DgLvLRX6ao7g5deE31SgAR+F6RwFXtMgNMpnmZhgt9C
QL/dnxwrjFvRxROu8Cg2ep0L/Bj+fpeHD5HlM7YxVPb8KY24wJc8njjZZ9u4k9kd
CbREMM3Avq/BMz3iL40mTPlsb1ywiDqkBXrPPAvNY4PVgLY5vbbCSK0d5/vjIgPT
CfojnIwmp2/M3CvQZxXTXg0nxkJ6xDqDJfKb/CooDBgx14j/m14qInYRnisIm5OE
f8J84b0oxsCtEi6v32aadrmdrOvZGKeaB2yyI0T7qc3WnYb2J9s=
=dRDJ
-----END PGP SIGNATURE-----
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel