[OpenWrt-Devel] [PATCH v3 2/5] ath79: WNR612v2: improve device support

[Adrian Schmutzler]

Hi,

just two annotations below.

> -			uboot: partition at 0 {
> +			partition at 0 {

You could also just keep it. But that's just a matter of taste.

>  &pcie {
> @@ -116,6 +122,8 @@
>  	ath9k: wifi at 0,0 {
>  		compatible = "pci168c,002b";
>  		reg = <0x0000 0 0 0 0>;
> +		mtd-mac-address = <&art 0x0>;
> +		mtd-mac-address-increment = <1>;

Calibration data is read here:
https://github.com/openwrt/openwrt/blob/master/target/linux/ath79/base-files/etc/hotplug.d/firmware/10-ath9k-eeprom#L184

Does this device get a MAC address from calibration data? If yes, I would prefer that one to a calculated address and remove the entries in DTS.
If not, I wonder whether your setup here will persist or being overwritten by some "wrong" address during calibration anyway. (Then one would have to use ath9k_patch_fw_mac in the linked file.

Best

Adrian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: openpgp-digital-signature.asc
Type: application/pgp-signature
Size: 834 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/openwrt-devel/attachments/20190812/157eda42/attachment.sig>
-------------- next part --------------
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel