[OpenWrt-Devel] [PATCH] ath79: ar7100: remove IRQ code from PCI driver

[Dmitry Tunin]

> > I see no reason of having two different ways of mask-ack for similar
> > hardware. We need to chose one that looks better and drop the other.
> I suggest discussing any irq-ath79-misc changes with the upstream developers
> Alban Bedel did *a lot* of work to make the ath79 code devicetree
> compatible. it would be a shame not to "use" his knowledge by
> including him in the discussion upstream

Now I see that the ack method for ar7240 is batantly wrong, probably
copied from some other place.
The driver was initially sent upsteam from Openwrt ;-)
I don't think anyone there looked into the hardware specs thoroughly.
I noticed this bug accidentally. Just got how the regs work and then
found that the ack is writing to a wrong reg.

We can always CC Alban.


> I suggest coordinating this with the upstream developers as well as
> that function is part of the upstream code

Lot's of things are part of upstream code ;-) But these type of things
are mostly developed here and sent upstream.

> > Any comments?
> slightly off-topic: please try not to top-post as it can be confusing
I am trying, but when I have to use web mailer I get in trouble with
that sometimes.

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel