[OpenWrt-Devel] [PATCH] ath79: ar71xx create a separate driver for ar71xx pci interrupt controller.

[Dmitry Tunin]

Yes, the IRQ 4 will go to bit 4. But anyway the IRQ4 is never
triggered, but we can leave it just in case someone needs it for
something ;-)
Now we can't "use hwirq 4" unless there is a handler in PCI driver.

I looked into the irq-ath79-misc.c and I think we need to change
ATH79_MISC_IRQ_COUNT.
We don't need that huge domain. According to spec the misc controller
has 8 IRQs and the PCI has actually 4, but we need 5 to be linear.
So 8 will be enough for both. But it must be another patch.
ср, 22 авг. 2018 г. в 10:11, Chuanhong Guo <gch981213 at gmail.com>:
>
> Dmitry Tunin <hanipouspilot at gmail.com> 于2018年8月22日周三 下午1:08写道：
> >
> > > > They are similar. I used that code as an example, but the
> > > > irq-ath79-pci has your mask/unmask for pci with reading the registers.
> > > > It is possible to make one driver for both, but is it really needed?
> > > It helps reducing code duplication.
> >
> > If we completely drop that PCI_CORE IRQ that we are not using anyway,
> > I see no reason why we can't
> > define 2 subnodes or the reset controller with the same irq-ath79-misc driver.
> I'm actually saying about directly using irq-ath79-misc for PCI
> interrupt, and this means define two nodes using different reg but
> make the compatible string the same(qca,ar7100-misc) :)
> And this doesn't mean that we can't use PCI_CORE IRQ if we need it.
> Simply use hwirq 0-2 for devices and hwirq 4 for PCI_CORE.
> > We'll need only to set PCI IRQs to 0-2 instead of 1-3. That's all.
> >
> > After some other feedback is received, I can do the change.
>
> _______________________________________________
> openwrt-devel mailing list
> openwrt-devel at lists.openwrt.org
> https://lists.openwrt.org/mailman/listinfo/openwrt-devel

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel