[OpenWrt-Devel] [PATCH v2] ath79: ag71xx: apply interface mode to MII0/1_CTRL on ar71xx/ar913x

[Mathias Kresin]

19.08.2018 09:02, Chuanhong Guo:
> Signed-off-by: Chuanhong Guo <gch981213 at gmail.com>

Please add a commit message. I'm sure you explained the issue and your 
fix somewhere. Not sure if I saw it in the forum or somewhere on github.

Good commit messages serve at least three important purposes:

  - To speed up the reviewing process.
  - To help us write a good release note.
  - To help the future maintainers, say five years into the future, to
    find out why a particular change was made to the code or why a
    specific feature was added.

A good commit message should answer three questions about a patch:

  - Why is it necessary? It may fix a bug, it may add a feature, it may
    improve performance, reliabilty, stability, or just be a change for
    the sake of correctness.
  - How does it address the issue? For short obvious patches this part
    can be omitted, but it should be a high level description of what the
    approach was.
  - What effects does the patch have? (In addition to the obvious ones,
    this may include benchmarks, side effects, etc.)

Mathias

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel