[OpenWrt-Devel] [PATCH v3] base-files: make wifi report unknown command

[Jonas Gorski]

On 9 August 2018 at 20:35, Thibaut <hacks at slashdirt.org> wrote:
>
>> On 9 Aug 2018, at 19:58, Jonas Gorski <jonas.gorski at gmail.com> wrote:
>>
>> On 9 August 2018 at 18:49, Thibaut VARÈNE <hacks at slashdirt.org> wrote:
>>> Avoid having /sbin/wifi silently ignore unknown keywords and execute
>>> "enable"; instead display the help message and exit with an error.
>>>
>>> Spell out the 'enable' keyword and preserve the implicit assumption
>>> that runing /sbin/wifi without argument performs "enable".
>>>
>>> Signed-off-by: Thibaut VARÈNE <hacks at slashdirt.org>
>>> ---
>>
>> Please keep a changelog here to know what's changed between submissions.
>
> it’s a 2-liner patch. I don’t think it warrants a changelog in the commit message :)

The fact that you needed to send 4 versions should be enough of an
argument to keep a changelog regardless of the size of the patch ;)

Also the changelog belongs below the tear-off line ("---") so it
doesn't end in the commit message.

So please keep that in mind for future patches.


Regards
Jonas

_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/mailman/listinfo/openwrt-devel