[OpenWrt-Devel] [PATCH] kirkwood: add support for Linksys EA3500

[Dan Walters]

Hi Karl!

On Thu, Oct 16, 2014, at 09:55 AM, Karl Palsson wrote:
> Just a minor one in the dts...
> 
> > ++	ocp at f1000000 {
> > ++		pinctrl: pinctrl at 10000 {
> > ++			pmx_led_green_power: pmx-led-green-power {
> > ++				marvell,pins = "mpp7";
> > ++				marvell,function = "gpo";
> 
> Shouldn't that really be gpio?

I wondered about that too, but in
Documentation/devicetree/bindings/pinctrl/marvell,kirkwood-pinctrl.txt,
the possible functions for mpp7 are listed as:

mpp7          7        gpo, pex(rsto), spi(cs), ptp(trig)

I just copied it from the EA4500 dts, and have tested that the LED
works, so seems to be correct.

> > ++	gpio_keys {
> > ++		compatible = "gpio-keys";
> > ++		#address-cells = <1>;
> > ++		#size-cells = <0>;
> > ++		pinctrl-0 = < &pmx_btn_wps &pmx_btn_reset >;
> 
> Why are there spaces around the <> here? (and below) I don't see that in
> any of the
> other dts files for pinctrl on
> http://lxr.free-electrons.com/source/arch/arm/boot/dts/kirkwood-*** for
> instance.

Indeed, looks like a lot of the kirkwood dts files have some spaces
around the pinctrl stuff, but probably shouldn’t have them.  I just
copied that part from the ea4500.  I’ll remove them.

Thanks for taking a look!

-Dan
_______________________________________________
openwrt-devel mailing list
openwrt-devel at lists.openwrt.org
https://lists.openwrt.org/cgi-bin/mailman/listinfo/openwrt-devel