firmware selector for openwrt.org

[Paul Spooren]

The refactored JSON script creates temporary files per created images 
and merges them together in a final step. This step is run automatically 
when running `make`, however the buildbot runs each step alone and the 
JSON merging was missing.

The refactoring happened because of concurrency issues, a single JSON 
file would be written by multiple running threads, resulting in 
unpredictable broken JSON files. With the merging step we can run slow 
steps in parallel (building images) and only the final merge happens in 
a single thread, creating the profiles.json file.

I created a buildbot patch here to add the step:
https://patchwork.ozlabs.org/project/openwrt/patch/20200630232801.2533530-1-mail@aparcar.org/

Best,
Paul

On 30.06.20 13:01, Moritz Warning wrote:
> The patch and that line already exists in master.
> But there seem to be no JSON file (profiles.json) in any image folder.
>
> On 7/1/20 12:06 AM, mail at adrianschmutzler.de wrote:
>>> -----Original Message-----
>>> From: openwrt-adm [mailto:openwrt-adm-bounces at lists.openwrt.org] On
>>> Behalf Of Moritz Warning
>>> Sent: Dienstag, 30. Juni 2020 23:39
>>> To: openwrt-adm at lists.openwrt.org
>>> Subject: Re: firmware selector for openwrt.org
>>>
>>> Point 1 has been resolved. - Great!
>>>
>>> Now the setting "Global build settings" => "Create JSON info file overview
>>> per target" would need to be enabled for the master and openwrt-19.07
>>> branches.
>>>
>>> How can we get this enabled? Does this require a vote?
>> Won't this be enabled for buildbots by default due to this line?
>>
>> https://github.com/openwrt/openwrt/blob/openwrt-19.07/config/Config-build.in#L12
>>
>> Best
>>
>> Adrian
>>
>>> Thanks,
>>> Moritz
>>>
>>> On 6/17/20 2:28 PM, Moritz Warning wrote:
>>>> This is the plan so far for the firmware selector:
>>>>
>>>> 1. get JSON output support into the openwrt-19.07 branch
>>>> (https://github.com/openwrt/openwrt/pull/3055)
>>>> 2. enable JSON file output on the build server (for 19.07 and
>>>> snapshots) 3. setup YAFS on openwrt.org
>>>>
>>>> On 6/8/20 8:39 PM, Moritz Warning wrote:
>>>>> hi,
>>>>>
>>>>> would it be desirable to have this for openwrt.org?
>>>>>
>>>>> https://mwarning.github.io/yet_another_firmware_selector/
>>>>>
>>>>> The setup would need the following OpenWrt option to create the JSON
>>> data:
>>>>> "Global build settings" ---> "[*] Create JSON info files per build image"
>>>>>
>>>>> And a script to merge it into one file.
>>>>>
>>>>> Thanks,
>>>>> Moritz
>>>>>
>>>>
>>>> _______________________________________________
>>>> openwrt-adm mailing list
>>>> openwrt-adm at lists.openwrt.org
>>>> http://lists.infradead.org/mailman/listinfo/openwrt-adm
>>>>
>>>
>>> _______________________________________________
>>> openwrt-adm mailing list
>>> openwrt-adm at lists.openwrt.org
>>> http://lists.infradead.org/mailman/listinfo/openwrt-adm
>
> _______________________________________________
> openwrt-adm mailing list
> openwrt-adm at lists.openwrt.org
> http://lists.infradead.org/mailman/listinfo/openwrt-adm